Difference in puppet-lint behavior between `pdk validate` and `rake lint` - Ruby pdk

pdk validate runs puppet-lint without any custom configuration, whereas the rake lint task as referenced in the default CI configs (https://github.com/puppetlabs/pdk-templates/blob/c43fc26e5607a038137ba3d7a9cb944eb171330b/configdefaults.yml#L78 and https://github.com/puppetlabs/pdk-templates/blob/c43fc26e5607a038137ba3d7a9cb944eb171330b/configdefaults.yml#L99, for example) disable several checks and exclude several files, as defined in puppetlabs_spec_helper: https://github.com/puppetlabs/puppetlabsspechelper/blob/07978467ed536ce1fcc8b2d0dbb830800e06c9b9/lib/puppetlabsspechelper/rake_tasks.rb#L172-L192

PuppetLint::RakeTask.new(:lint) do |config|
  config.fail_on_warnings = true
  config.disable_checks = %w[
    80chars
    140chars
    class_inherits_from_params_class
    class_parameter_defaults
    disable_autoloader_layout
    documentation
    single_quote_string_with_variables
  ]
  config.ignore_paths = [
    '.vendor/**/*.pp',
    'bundle/**/*.pp',
    'pkg/**/*.pp',
    'spec/**/*.pp',
    'tests/**/*.pp',
    'types/**/*.pp',
    'vendor/**/*.pp',
  ]
end

I think it would be preferable for the default configuration to match between the two projects maintained by Puppet.

Asked Oct 05 '21 03:10

nabertrand