osm install --set arguments should override default flag values Go

This behavior is intended, though I understand it's not ideal.

The help text for the flag does address this behavior somewhat:

--set stringArray                         Set arbitrary chart values not settable by another flag...

--set doesn't override the other flags because currently the validation for those values is tied to the CLI flag. The current behavior ensures that validation can't be bypassed using --set.

1

Answered Mar 10 '21 at 20:40

nojnhuh

--set doesn't override the other flags because currently the validation for those values is tied to the CLI flag. The current behavior ensures that validation can't be bypassed using --set.

This should be resolvable with a bit of refactoring, right? We'd just have to "merge" the set values first, then validate, then resolve.

1

Answered Mar 10 '21 at 20:56

ksubrmnn

Yeah, that should work. My only concern is the error messages will probably say something like OpenServiceMesh.envoyLogLevel not valid... if a user does osm install --envoy-log-level=invalid. Usually the mapping between osm install flags and values is easy enough to figure out, but I could see that being unclear.

1

Answered Mar 10 '21 at 21:15

nojnhuh

Can we make the usage of chart param specific flags consistent with either using the CLI flags or using --set and ensuring we can validate every param passed to --set? There needs to be a clear guidance on when to use a CLI flag vs --set. Otherwise this is going to introduce more inconsistency in the code and make it hard to reason. I don't believe we should be providing multiple ways to set the same chart param, its just harder to maintain and reason.

1

Answered Mar 10 '21 at 22:17

shashankram

Commit bff18e72c702478ee588433547d80b17240d8e83 removed custom CLI flags for the install commands in favor of using --set, so this issue should be resolved.

1

Answered Sep 10 '21 at 17:44

shashankram